Fix icon alignment in page listings #11870
Merged
+15
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://laymonagefix-page-listing-icon-01lce.squash.io |
laymonage
added
type:Bug
status:Needs Review
component:Design system
laymonage
force-pushed
the
fix-page-listing-icons
branch
from
50ddaf7
to
9d40ca1
Compare
|
The second commit fixes #11875. (Not exactly the same as it was in 6.0 but if we use 
|
thibaudcolas
approved these changes
Apr 30, 2024
| @@ -4,6 +4,7 @@ | |||
| border-radius: 2px; | |||
| text-align: center; | |||
| display: inline-block; | |||
| flex-shrink: 0; | |||
There was a problem hiding this comment.
As discussed we’ll change this to word-break: normal to fix #11875 while reducing the risk of page titles being squashed by long locale names (Portuguese (Brazil) (latest)).
This was added in f322e9d, when the snippets listing view was briefly redesigned to put the "Edit", "Delete" etc. actions in the same line as the title instead of in a new line. With the universal listings design, all listing actions are put inside a three-dot dropdown menu. This style is no longer used anywhere in Wagtail, especially now that the HistoryView has been reimplemented using the dropdown menu for the actions.
thibaudcolas
force-pushed
the
fix-page-listing-icons
branch
from
2aa6475
to
5927b12
Compare
laymonage
commented
May 7, 2024
Comment on lines
+226
to
+229
| display: flex; | ||
| align-items: center; | ||
| justify-content: space-between; | ||
| gap: theme('spacing.2'); |
There was a problem hiding this comment.
Unfortunately this caused unexpected styling issues elsewhere 🤦
I'll create a PR to fix this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue on Safari introduced in bb12877, while also improving the alignment of the site/folder icon on other browsers. The second commit fixes #11875.
Safari before/after
Screenshots
Chrome before/after
Screenshots
Firefox before/after
Screenshots