Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contrast themes / WHCM support improvements #11449

Open
27 tasks
thibaudcolas opened this issue Jan 12, 2024 · 5 comments · May be fixed by #11741
Open
27 tasks

Contrast themes / WHCM support improvements #11449

thibaudcolas opened this issue Jan 12, 2024 · 5 comments · May be fixed by #11741

Comments

@thibaudcolas
Copy link
Member

thibaudcolas commented Jan 12, 2024

Issues reported by @albinazs as part of WCAG 2.2 accessibility audit – still to be confirmed.

Working on this

Those issues are unconfirmed – please only pick these up unless you’re comfortable with forced-colors mode / WHCM, and able to understand which area of Wagtail is mentioned. The first step will be to confirm the issues via comments here, then devise a fix.

Issues

Tooltips

  • Broken design for data-w-tooltip human readable date (no border, solid square instead of an arrow): w-human-readable-date
  • Broken design for tooltips for sidebar-slim menu items (no border, solid square instead of an arrow)
  • Absent border for the Actions tooltip
  • Absent border for the Status tooltip
  • Absent border for the Actions, Status, Preview, Comments, History and Live tooltips on the editor's header
  • Absent border for the Actions tooltip on the Image:
<button type="button" class="w-dropdown__toggle w-dropdown__toggle--icon" data-w-dropdown-target="toggle" aria-label="Actions" aria-describedby="id_image-title" aria-expanded="false">

Menus and menu items

  • No circle around Wagtail brand logo: sidebar-wagtail-branding__icon-wrapper
  • Button and links styled as buttons have different appearance on the main menu as well as menu footer which is confusing
  • No visible state change on hover for menu and menu footer items
  • Low contrast for submenu header icons: suitcase
  • No visible right border for the submenu header & drawer, that separates visually menu from the page content
  • Unnecessary 3px solid right and left borders on all the menu items
  • No visual indication of the chosen parent menu item when submenu is opened (except Highlight color on the extra left & right borders that seems to work only for some of the items like Pages and Bread categories)

Code:

w-page-explorer

Side panels

  • No visible state change on hover for the minimap items including Expand-right icon. Same goes for the most of every form-side panel's items: w-minimap__list
  • Unnecessary 3px solid left border on the minimap items: w-minimap__list
  • Broken design for the form resize grip for all form panels (square on the right instead of 2 thin central lines)

Light theme only

  • invisible Admin arrow icon in both open and closed states

Dark theme only

  • 'Warning' icon has very low contrast
  • disappearing 'plus' sign on the comment icon on hover
  • very low contrast for the Close button on the 'Change privacy' and 'Set schedule' dialogs on the History panel

Other

  • No visible hover effect for almost all the items on the dashboard
  • Absent border around the language label: w-status w-status--label
  • Inconsistent focus appearance for the Actions dropdown items on the footer - thick ButtonText outline instead of the Highlight like for the rest of the components on the page
  • No visible state change on hover for the date picker's days and light & left months navigation arrows
  • Inconsistent focus appearance for the Draftail containers (ButtonText border instead of a Highlight one like on Text inputs
  • Inconsistent appearance of the plus buttons on hover: Highlight border for the combobox and Green background for adding a block respectively: c-sf-add-button
  • Weird hover appearance for the combobox option items (background change): <div class="w-combobox">...</div>
@thibaudcolas thibaudcolas added type:Bug Accessibility status:Unconfirmed Issue, usually a bug, that has not yet been validated as a confirmed problem. and removed status:Unconfirmed Issue, usually a bug, that has not yet been validated as a confirmed problem. labels Jan 12, 2024
@nandini584
Copy link
Contributor

I have gone through the code and I can confirm that these issues exist. I would like to give this a shot.

@lb-
Copy link
Member

lb- commented Mar 2, 2024

Go for it @nandini584 - feel free to start with a small scale PR that fixes a few things.

@nandini584
Copy link
Contributor

I have raised a small-scale PR, but I am confused about the changes to make, 1. For the main menu and main footer, are they designed separately I couldn't find the main footer. 2. No visible state changes on hover, what do you mean by this, the opacity does change on hovering the menu items.

@laymonage
Copy link
Member

@nandini584

  1. No visible state changes on hover, what do you mean by this, the opacity does change on hovering the menu items.

Are you sure you're testing with the forced-colors mode? The opacity does change without the forced-colors mode, but it does not change when forced-colors is active, which is an issue.

Please note that as mentioned in the "Working on this" description of this issue, the listed issues are applicable to forced-colors mode/Windows High Contrast Mode. If you're not familiar with what it is, it is suggested that you look into that feature before working on this issue.

@nandini584
Copy link
Contributor

Sure, I will look into this. Thanks.

@nandini584 nandini584 linked a pull request Mar 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
4 participants