Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ready for review] Bahasa Indonesia - An alt Decision Tree #737

Merged
merged 8 commits into from Mar 21, 2024

Conversation

frirasyidi
Copy link

Add Bahasa Indonesia translation

Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for wai-tutorials2 ready!

Name Link
🔨 Latest commit 97127ba
🔍 Latest deploy log https://app.netlify.com/sites/wai-tutorials2/deploys/65f99f0504466b0008568ae3
😎 Deploy Preview https://deploy-preview-737--wai-tutorials2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@frirasyidi frirasyidi marked this pull request as draft December 5, 2023 07:01
@frirasyidi
Copy link
Author

frirasyidi commented Dec 5, 2023

@remibetin I noticed that the frontmatter for the footer is slightly different and made some keys left untranslated:

editors:
  - Eric Eggert: "https://www.w3.org/People/yatil/"
  - Shadi Abou-Zahra: "https://www.w3.org/People/shadi/"
update_editors:
  - Brian Elton
contributors:
  - see <a href="/WAI/tutorials/acknowledgements/">Acknowledgements</a>
support: Developed by the Education and Outreach Working Group (<a href="https://www.w3.org/groups/wg/eowg">EOWG</a>). Developed with support from the <a href="https://www.w3.org/WAI/ACT/">WAI-ACT project</a>, co-funded by the <strong>European Commission <abbr title="Information Society Technologies">IST</abbr> Programme</strong>.

Notice the rendered translated page below does not have the proper translation for some words such as "updated", "editors", "and", as well as "contributors".

Screen Shot 2023-12-05 at 15 24 10

Should I raise this as separate issue, or is there something missing that I need to do to fix this?

@remibetin
Copy link
Member

Hi @frirasyidi

Thank you very much for this translation!

Notice the rendered translated page below does not have the proper translation for some words such as "updated", "editors", "and", as well as "contributors".
Should I raise this as separate issue, or is there something missing that I need to do to fix this?

Indeed, thank you for your thoroughness! Those terms need translation in another file/repo: https://github.com/w3c/wai-website-data/blob/master/translations.yml (from line 1087)

Would you open a Pull Request in https://github.com/w3c/wai-website-data to propose Indonesian translations for those terms?

@remibetin remibetin linked an issue Dec 5, 2023 that may be closed by this pull request
@frirasyidi
Copy link
Author

Would you open a Pull Request in https://github.com/w3c/wai-website-data to propose Indonesian translations for those terms?

@remibetin you can find the updated translation PR here: w3c/wai-website-data#116

@remibetin remibetin changed the title [In Progress] Bahasa Indonesia - An alt Decision Tree [Ready for review] Bahasa Indonesia - An alt Decision Tree Dec 6, 2023
@remibetin remibetin marked this pull request as ready for review December 6, 2023 14:02
Fri added 2 commits January 15, 2024 13:45
    - dapat --> bisa
    - dapat diterima indra --> dapat ditangkap
Copy link
Member

@remibetin remibetin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @frirasyidi,

I have added a comment to your translation. Can you take a look?

content/images/decision-tree.id.md Outdated Show resolved Hide resolved
@remibetin
Copy link
Member

@frirasyidi FYI, I have separated your translation into 2 PRs:

@remibetin remibetin assigned shawna-slh and unassigned frirasyidi Mar 18, 2024
@shawna-slh shawna-slh merged commit bf7b7ab into w3c:master-2.0 Mar 21, 2024
4 of 7 checks passed
@remibetin
Copy link
Member

QA done: ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bahasa Indonesia - An alt Decision Tree
3 participants