Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding tip about responsive design and tables #718

Merged
merged 5 commits into from May 13, 2024

Conversation

brianelton
Copy link
Collaborator

Adding note from #526 regarding Responsive design. Covers #593

@brianelton
Copy link
Collaborator Author

Holding off on merging PR to see if we should add some more info regarding CSS grid layouts

@shawna-slh
Copy link
Contributor

@@ -31,6 +31,8 @@ support: Developed by the Education and Outreach Working Group (<a href="https:/

- **Keep it simple:** Complex tables are more work for content creators as well as being harder to interpret for users. It’s usually better to [break up complex tables into simple individual tables](/tutorials/tables/multi-level/#split-up-multi-level-tables), each containing the data for one sub-topic.

- **Responsive design:** On smaller screens, responsive tables often change format. Ensure that the structural relationship is available in all formats.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to include users with high zoom and/or large fonts. (I don't have a specific wording suggestion now though.)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "On smaller screens, or when viewing content in a small viewport, responsive tables..." ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated this.

@netlify
Copy link

netlify bot commented Jul 21, 2023

Deploy Preview for wai-tutorials2 ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/wai-tutorials2/deploys/662f91c6e55fa31339716203
😎 Deploy Preview https://deploy-preview-718--wai-tutorials2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brianelton
Copy link
Collaborator Author

@shawna-slh any further comments before merging?

@shawna-slh
Copy link
Contributor

"On smaller screens, or when viewing content in a small viewport, responsive tables..."

hum, this doesn't address my point. I have a large monitor and the viewport max -- so neither "On smaller screens, or when viewing content in a small viewport".

However, with large text and increased line spacing &/or browser zoom, I still get the "responsive" view.

@brianelton
Copy link
Collaborator Author

@shawna-slh how about "On smaller screens, or when viewing content in a small viewport, zoomed screen, or otherwise adjusted view, responsive tables often change format."

@brianelton brianelton added ready to merge PR is ready to merge but need to wait for appropriate time and removed EOWG Review labels Nov 9, 2023
@shawna-slh
Copy link
Contributor

how about: "Responsive design: On small screens, in a small viewport, in zoomed views, with enlarged text, and other situations, responsive tables often change format. Ensure that the structural relationship is available in all formats."
?

@brianelton
Copy link
Collaborator Author

@shawna-slh yes, that looks good. I have updated it.

@brianelton
Copy link
Collaborator Author

@shawna-slh please merge this PR

@shawna-slh
Copy link
Contributor

Thanks Brian!
/me not able to make time to review. OK for @remibetin to merge and publish

@remibetin remibetin merged commit 3a628f4 into master-2.0 May 13, 2024
4 of 7 checks passed
@remibetin remibetin deleted the responsive-tables-593 branch May 13, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge PR is ready to merge but need to wait for appropriate time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants