Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the description for aria-labelledby #596

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

niwsa
Copy link

@niwsa niwsa commented Nov 1, 2019

Reference => https://www.w3.org/TR/wai-aria-1.1/#aria-label

aria-labelledby is used when content is visible either via tooltip or visible text.

@yatil yatil self-requested a review November 27, 2019 09:55
@yatil
Copy link
Contributor

yatil commented Nov 27, 2019

@niwsa I think your change is not what we want to say with this (terribly long and hard to understand) sentence. I think what we want to say is:

The aria-labelledby attribute can also be used to identify form controls. This approach is well supported by screen readers and other assistive technology. Unlike the title attribute (see below), the information is not conveyed to visual users by default. This approach should therefore only be used when the label of the control is clear from the surrounding content, like the button in the example below.

Then, we should probably add a sentence about title being not available to many users (like ones using speech input or keyboard-only).

Thanks for creating this PR. I try to make some changes soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants