Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousels Styling for Mobile #528

Closed
wants to merge 1 commit into from
Closed

Carousels Styling for Mobile #528

wants to merge 1 commit into from

Conversation

brewerj
Copy link

@brewerj brewerj commented Jun 23, 2017

Proposed new tip ("Responsive design") to improve coverage for responsive design of carousels.

If confirmed, add note "Developed with support from WCAG TA Project"

@brewerj brewerj self-assigned this Jun 23, 2017
@yatil yatil changed the title Update styling.html.erb.md Carousels Styling for Mobile Jun 23, 2017

## For smaller screens

Make sure carousel text is not too small or cut off from view. Also, make sure touch access works well on the small dots that control the slides.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally agreeing with the paragraph (which could be further up the page), some wording:

Make sure carousel text is not too small or cut off from view. Also, make sure touch access works well on the small dots that control the slides.

What about:

Make sure carousel text is not too small or cut off from view. Navigation buttons, like all interactive elements, need to be easy to tap and have associated labels.

(The link will link to there: https://www.w3.org/WAI/tutorials/carousels/functionality/#add-navigation-buttons)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like @yatil's suggested wording changes. This may be a bit redundant, but perhaps we can further clarify the paragraph (edited text in bold) to say:

Make sure carousel text is not too small or cut off from view. Navigation buttons to control the slides, like all interactive elements, need to be easy to tap and have associated labels.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... must be large enough to tap ... ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 @iamjolly and for editor's discretion: I get a bit weary of the overuse of "make sure" in our guidance documents and would amend to say "Avoid use of text that is too small for easy reading or that is cut off."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to @iamjolly @sharronrush. but like Andrew's phrase suggestion. Okay with editor's discretion for the various wording options.

@yatil yatil added the mobile label Jun 28, 2017
@nrhsinclair
Copy link

Regarding Carousel text size, is there a recommendation on a preferred size that is "not too small" and is "large enough", ex.
Carousel text should be at least XX size and should not be cut off from view.

@brianelton
Copy link
Collaborator

Pulling together the comments:
"Avoid use of text that is too small for easy reading or that is cut off. Navigation buttons to control the slides, like all interactive elements, need to be large enough to tap and have associated labels."

@brianelton
Copy link
Collaborator

The first part of this page has info about button size, so part of this new section may be redundant and unnecessary. Perhaps the messaging should be that even in a smaller viewport there should still be navigation buttons and not just rely on swiping to move the carousel items.

"Avoid use of text that is too small for easy reading or that is cut off. Navigation buttons to control the slides should still be present to avoid the reliance on swipe gestures"

@lakeen
Copy link

lakeen commented May 9, 2023

I agree with @brianelton. The button size text is very specific:

Button Size
Use appropriately sized buttons and links, and provide whitespace around them, to allow people with reduced dexterity to use the carousel more easily. This also benefits people using touch screens, such as on mobile devices. Buttons and links that are not inline in a block of text should be at least 44 × 44 CSS pixels.

So +1 to:

"Avoid use of text that is too small for easy reading or that is cut off. Navigation buttons to control the slides should still be present to avoid the reliance on swipe gestures"

@brianelton
Copy link
Collaborator

Updates covered in #721. Closing PR.

@brianelton brianelton closed this May 9, 2023
@brianelton brianelton deleted the brewerj-patch-3 branch May 9, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet