-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carousels Styling for Mobile #528
Conversation
|
||
## For smaller screens | ||
|
||
Make sure carousel text is not too small or cut off from view. Also, make sure touch access works well on the small dots that control the slides. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally agreeing with the paragraph (which could be further up the page), some wording:
Make sure carousel text is not too small or cut off from view. Also, make sure touch access works well on the small dots that control the slides.
What about:
Make sure carousel text is not too small or cut off from view. Navigation buttons, like all interactive elements, need to be easy to tap and have associated labels.
(The link will link to there: https://www.w3.org/WAI/tutorials/carousels/functionality/#add-navigation-buttons)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like @yatil's suggested wording changes. This may be a bit redundant, but perhaps we can further clarify the paragraph (edited text in bold) to say:
Make sure carousel text is not too small or cut off from view. Navigation buttons to control the slides, like all interactive elements, need to be easy to tap and have associated labels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 @iamjolly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... must be large enough to tap ... ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 @iamjolly and for editor's discretion: I get a bit weary of the overuse of "make sure" in our guidance documents and would amend to say "Avoid use of text that is too small for easy reading or that is cut off."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to @iamjolly and @sharronrush
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to @iamjolly @sharronrush
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to @iamjolly @sharronrush. but like Andrew's phrase suggestion. Okay with editor's discretion for the various wording options.
Regarding Carousel text size, is there a recommendation on a preferred size that is "not too small" and is "large enough", ex. |
Pulling together the comments: |
The first part of this page has info about button size, so part of this new section may be redundant and unnecessary. Perhaps the messaging should be that even in a smaller viewport there should still be navigation buttons and not just rely on swiping to move the carousel items. "Avoid use of text that is too small for easy reading or that is cut off. Navigation buttons to control the slides should still be present to avoid the reliance on swipe gestures" |
I agree with @brianelton. The button size text is very specific: Button Size So +1 to: "Avoid use of text that is too small for easy reading or that is cut off. Navigation buttons to control the slides should still be present to avoid the reliance on swipe gestures" |
Updates covered in #721. Closing PR. |
Proposed new tip ("Responsive design") to improve coverage for responsive design of carousels.
If confirmed, add note "Developed with support from WCAG TA Project"