Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update diagram to better reflect unload timing #198

Merged
merged 1 commit into from Mar 7, 2024
Merged

Update diagram to better reflect unload timing #198

merged 1 commit into from Mar 7, 2024

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Mar 7, 2024

Closes #197

@noamr noamr requested a review from tunetheweb March 7, 2024 13:12
tunetheweb
tunetheweb approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@noamr noamr merged commit 78300ff into gh-pages Mar 7, 2024
2 checks passed
@tunetheweb tunetheweb mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tunetheweb tunetheweb tunetheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Process Unload Event" in wrong place on timing diagram
2 participants
@noamr @tunetheweb