Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update diagram to make unload parallel #191

Merged
merged 4 commits into from Oct 24, 2023
Merged

Update diagram to make unload parallel #191

merged 4 commits into from Oct 24, 2023

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Oct 24, 2023

This was erroneously reverted by an unrelated diagram change.

@noamr noamr requested a review from yoavweiss October 24, 2023 09:40
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do you know if there are any WPT to confirm all browsers act like this?

Also, on an unrelated note I wonder if we should include firstInterimResponseStart while we're at it.

@noamr
Copy link
Contributor Author

noamr commented Oct 24, 2023

LGTM.

Do you know if there are any WPT to confirm all browsers act like this?

Since unload is about to be deprecated, I wouldn't want to spend too much cycles on this.

Also, on an unrelated note I wonder if we should include firstInterimResponseStart while we're at it.

Done

@tunetheweb
Copy link
Member

I think you need to extend the "Resource Timing" dotted line to include the Response box? Previously this was only half of the Response box but not sure why (shouldn't it be all the Response box). Also seems to be a gap before the title:

image

@noamr
Copy link
Contributor Author

noamr commented Oct 24, 2023

I think you need to extend the "Resource Timing" dotted line to include the Response box? Previously this was only half of the Response box but not sure why (shouldn't it be all the Response box). Also seems to be a gap before the title:

image

Done

@tunetheweb
Copy link
Member

Thanks, but I still see the space to the left of the title of that dotted section (I'm getting real picky now!):

image

@noamr
Copy link
Contributor Author

noamr commented Oct 24, 2023

Thanks, but I still see the space to the left of the title of that dotted section (I'm getting real picky now!):

image

How is it now?

@tunetheweb
Copy link
Member

OK now it definitely LGTM! Thanks for addressing my concerns!

@noamr
Copy link
Contributor Author

noamr commented Oct 24, 2023

OK now it definitely LGTM! Thanks for addressing my concerns!

Thanks for helping make this better!

@noamr noamr merged commit 384ff3e into gh-pages Oct 24, 2023
2 checks passed
@noamr noamr deleted the update-diag branch October 24, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants