Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify sub-type requirement for cloning tracks #864

Closed
wants to merge 2 commits into from
Closed

Specify sub-type requirement for cloning tracks #864

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84e515f
Specify subtype when cloning tracks
eladalon1983 Feb 24, 2022
4f7a02c
Merge branch 'main' of https://github.com/eladalon1983/mediacapture-main
eladalon1983 Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 6 additions & 3 deletions getusermedia.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,9 +697,12 @@ <h2>{{MediaStreamTrack}}</h2>
{{MediaStreamTrack/[[Source]]}}.</p>
</li>
<li>
<p>Let <var>trackClone</var> be the result of
[=create a MediaStreamTrack | creating a MediaStreamTrack=] with
<var>source</var> and the value <code>false</code>.
<p>
Let <var>trackClone</var> be the result of
[=create a MediaStreamTrack | creating a MediaStreamTrack=] with
<var>source</var> and the value <code>false</code>.
<var>trackClone</var> MUST be of the same sub-type of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest phrasing as "If track is a subclass of MediaStreamTrack, and the subclass does not specify a different rule for "clone", trackClone MUST be an object of the same subclass.

{{MediaStreamTrack}} as <var>track</var>.
</p>
</li>
<li>
Expand Down