Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify sub-type requirement for cloning tracks #864

Closed
wants to merge 2 commits into from
Closed

Specify sub-type requirement for cloning tracks #864

wants to merge 2 commits into from

Conversation

eladalon1983
Copy link
Member

@eladalon1983 eladalon1983 commented Mar 3, 2022 •
edited by pr-preview bot

Fixed #857.

Preview | Diff

alvestrand
alvestrand reviewed Mar 3, 2022
View reviewed changes
getusermedia.html
Let <var>trackClone</var> be the result of
[=create a MediaStreamTrack | creating a MediaStreamTrack=] with
<var>source</var> and the value <code>false</code>.
<var>trackClone</var> MUST be of the same sub-type of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest phrasing as "If track is a subclass of MediaStreamTrack, and the subclass does not specify a different rule for "clone", trackClone MUST be an object of the same subclass.

@youennf
Copy link
Contributor

youennf commented Mar 3, 2022

I think we should change the create a MediaStreamTrack algorithm instead.
In particular, we could have the source has a MediaStreamTrackType slot.
If the slot is there, we would create a track of type MediaStreamTrackType, defaulting to MediaStreamTrack.
We might need to add some extension points for being able to initialize additional slots.
I would hope we can do that inside create a MediaStramTrack algorithm.
This would solve the transfer case as well. I can have a stab at what I have in mind if I am not clear here.

@eladalon1983
Copy link
Member Author

I can have a stab at what I have in mind if I am not clear here.

Be my guest. :-)

@dontcallmedom dontcallmedom mentioned this pull request Nov 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvestrand alvestrand alvestrand left review comments

@youennf youennf Awaiting requested review from youennf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@eladalon1983 @youennf @alvestrand