Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errata link text #2562

Merged
merged 4 commits into from
May 19, 2023
Merged

Fix errata link text #2562

merged 4 commits into from
May 19, 2023

Conversation

mattgarrish
Copy link
Member

@mattgarrish mattgarrish commented May 18, 2023

This code changes the errata links from "Errata exists" to the URL to the errata file.

Ideally, we'll be able to strip this code whenever speced/respec#4446 is resolved, but all the live notes currently say errata exists for them.


Preview | Diff

@mattgarrish mattgarrish requested a review from iherman May 18, 2023 15:15
Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the same changes be done on the three rec texts, too? We may republish new versions within 2-3 months to handle the obvious errata, and we shouldn't expect that respec issue to be handled with a high priority...

@mattgarrish
Copy link
Member Author

Ya, good point. Probably over-optimistic on my part to think it'll be fixed quickly. I'll add to those, as well.

@mattgarrish mattgarrish merged commit 1402124 into main May 19, 2023
7 checks passed
@mattgarrish mattgarrish deleted the fix/errata-text branch May 19, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants