Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify none and unknown are not valid features #2547

Merged
merged 5 commits into from
Apr 4, 2023

Conversation

mattgarrish
Copy link
Member

@mattgarrish mattgarrish commented Mar 27, 2023

It doesn't make sense to require that features be specified but also allow these values, so this pull request adds a paragraph explaining that the values are not allowed to meet the reporting requirements.

Fixes #2537

@madeleinerothberg
Copy link
Collaborator

Consider adding one more phrase to the end of the paragraph, so that it reads something like this:

Authors must indicate at least one feature to claim conformance to EPUB Accessibility 1.1.

@mattgarrish
Copy link
Member Author

@clapierre @gregoriopellegrino @avneeshsingh @GeorgeKerscher are you guys okay with merging this and adding unknown to the schema.org vocabulary?

@GeorgeKerscher
Copy link

Hi, So I see the following:
Be aware that although the vocabulary for the accessibilityFeature property [a11y-discov-vocab] contains the values "none" and "unknown", these terms cannot be used to meet the reporting requirements for the property. Authors must indicate at least one feature.
Refer to The accessibilityFeature Property [a11y-discov-vocab] for more information about this property and its values.

I think this is fine.
/George

@mattgarrish
Copy link
Member Author

Thanks George!

Authors must indicate at least one feature.

Per @madeleinerothberg's suggestion above, this last sentence now reads: "Authors must indicate at least one feature to claim conformance to EPUB Accessibility 1.1."

@gregoriopellegrino
Copy link
Contributor

For non-native English readers, I would add (redundantly):

at least one feature (apart from none and unknown)

Copy link
Contributor

@gregoriopellegrino gregoriopellegrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mattgarrish
Copy link
Member Author

I used slightly different wording to avoid repeating the terms again as I was looking at the vocabulary and some day we might want to look at listing the other values that aren't applicable to epubs, like taggedPDF.

@madeleinerothberg
Copy link
Collaborator

Looks good! I agree that the additional-additional phrase adds clarity.

@mattgarrish mattgarrish merged commit daee913 into main Apr 4, 2023
@mattgarrish mattgarrish deleted the a11y/feat-unknown-invalid branch April 4, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility feature of none and conformance
5 participants