-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify none and unknown are not valid features #2547
Conversation
…ting requirements for accessibilityFeature
Consider adding one more phrase to the end of the paragraph, so that it reads something like this: Authors must indicate at least one feature to claim conformance to EPUB Accessibility 1.1. |
@clapierre @gregoriopellegrino @avneeshsingh @GeorgeKerscher are you guys okay with merging this and adding unknown to the schema.org vocabulary? |
Hi, So I see the following: I think this is fine. |
Thanks George!
Per @madeleinerothberg's suggestion above, this last sentence now reads: "Authors must indicate at least one feature to claim conformance to EPUB Accessibility 1.1." |
For non-native English readers, I would add (redundantly):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I used slightly different wording to avoid repeating the terms again as I was looking at the vocabulary and some day we might want to look at listing the other values that aren't applicable to epubs, like taggedPDF. |
Looks good! I agree that the additional-additional phrase adds clarity. |
It doesn't make sense to require that features be specified but also allow these values, so this pull request adds a paragraph explaining that the values are not allowed to meet the reporting requirements.
Fixes #2537