Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rendition:flow for webtoon-like publications #2441

Merged
merged 3 commits into from
Sep 27, 2022
Merged

rendition:flow for webtoon-like publications #2441

merged 3 commits into from
Sep 27, 2022

Conversation

iherman
Copy link
Member

@iherman iherman commented Sep 23, 2022

This is the implementation of the WG resolution (see #2412).

See:

@iherman iherman assigned davemanhall and unassigned davemanhall Sep 23, 2022
@iherman iherman changed the title Added a note and change item rendition:flow for webtoon-like publications Sep 23, 2022
Copy link

@davemanhall davemanhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -1715,6 +1715,17 @@ <h4>The <code>rendition:flow</code> property</h4>
<p>Reading systems MUST ignore the <code>rendition:flow</code> property and its overrides when
processing <a href="https://www.w3.org/TR/epub-33/#def-layout-pre-paginated">pre-paginated spine
items</a> [[epub-33]].</p>

<p class="note">
Reading systems may decide to disregard this restriction, and accept
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, but it's kind of weird to say that RSes will decide things. I'd either drop "decide to" from this sentence or change it to "Reading system developers".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, will change

@mattgarrish
Copy link
Member

It might help to also add a link to the deferred issue to the note so people can add feedback and/or find out more about where we are with future implementation.

@iherman
Copy link
Member Author

iherman commented Sep 27, 2022

@mattgarrish, I've made the changes.

epub33/rs/index.html Outdated Show resolved Hide resolved
@mattgarrish
Copy link
Member

Thanks, looks good to me other than the one last typo.

Co-authored-by: Matt Garrish <mattgarrish@users.noreply.github.com>
@iherman iherman merged commit 093b9a1 into main Sep 27, 2022
@iherman iherman deleted the webtoon-note branch September 27, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants