Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AS2 Ontology: Added relationships defined in JSON-LD context. #566

Closed
wants to merge 1 commit into from

Conversation

steve-bate
Copy link

No description provided.

Copy link
Member

@csarven csarven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is some grounds to not introduce this into the RDF. AFAICT, #406 was resolved with the understanding to remove these classes from the normative specs however they were not removed from the JSON-LD context.

I suggest closing this PR.

See follow up: #574 .

@steve-bate
Copy link
Author

I think there is some grounds to not introduce this into the RDF. AFAICT, #406 was resolved with the understanding to remove these classes from the normative specs however they were not removed from the JSON-LD context.

I suggest closing this PR.

See follow up: #574 .

I think it makes sense to at least add comments to the OWL referencing the pending issue to provide a description of the situation to others comparing the OWL model with the JSON-LD context. I'll make that change.

@csarven
Copy link
Member

csarven commented Dec 28, 2023

I suggest that we process PR 574 before processing this PR 566.

I don't see the urgency in adding information to the OWL - it is not just comments but actual statements - even if temporarily, when it appears to be that information shouldn't be there to begin with.

If 574 is merged, we'll have to undo 566.

If 574 is rejected, and that the relationships somehow should be re-introduced/defined in the Vocabulary, only then 566 is useful. My preference would be to leave out the information for the time being instead of introducing information that in all likelihood doesn't belong.

@steve-bate
Copy link
Author

I suggest that we process PR 574 before processing this PR 566.

I don't see the urgency in adding information to the OWL - it is not just comments but actual statements - even if temporarily, when it appears to be that information shouldn't be there to begin with.

Fair enough. I maintain a fork of the ontology and I'll do active maintenance on that to keep in sync with the current JSON-LD normative context (as much as possible). It's easy to change it if and when the normative JSON-LD context issue is addressed (it's been almost 7 years now).

If 574 is merged, we'll have to undo 566.

That's true, but is it a problem? My understanding (based on historical @jasnell comments) is that the OWL ontology is intentionally not normative so it can be maintained by the community with less bureaucracy than the normative documents. The comment removal could be part of the commit that fixes the normative context and would only take a few minutes to prepare.

If 574 is rejected, and that the relationships somehow should be re-introduced/defined in the Vocabulary, only then 566 is useful. My preference would be to leave out the information for the time being instead of introducing information that in all likelihood doesn't belong.

While it's true that we can't predict the future or how long it will take to fix the normative JSON-LD context (this issue has existed for almost 7 years now), we can take action on what we know today. The action I'm proposing is to document the current discrepancies and the expected resolution as comments in the ontology for the benefit of those using it and cross-referencing it to normative documents.

@steve-bate steve-bate closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants