Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example 183 lat/lon values to Numbers, not String #451

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gobengo
Copy link
Contributor

@gobengo gobengo commented Jan 24, 2018

Resolves #446

@evanp evanp closed this May 9, 2018
@kaleb
Copy link

kaleb commented Jan 30, 2020

Shouldn't this have been fixed in the file https://github.com/w3c/activitystreams/blob/master/test/vocabulary-ex183-jsonld.json instead? And the re-gen the php @gobengo ?

@gobengo
Copy link
Contributor Author

gobengo commented Jan 30, 2020

@kaleb I don't believe the index.html is generated from those example json files.

Also have no idea why @evanp closed this. Still seems right to have those be numbers and not strings. All the other uses of the latitude/longitude properties in the vocabulary document use numbers.

@dontcallmedom
Copy link
Member

The problem was documented in the errata from what I can see:
3b5df7a

That said, fixing the main HTML file itself would still make sense I think, so re-opening the pull request (at the very least, documenting why it should be closed would be better)

@dontcallmedom dontcallmedom reopened this Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example 150: Latitude/Longitude are not xsd:float
4 participants