Ported to python3 #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,6 +38,8 @@ def remove(self, fd): | |||
|
|
|||
| def write(self, data): | |||
| for ind in self.base: | |||
| if sys.version_info >= (3, 0): | |||
| data = str(data) | |||
There was a problem hiding this comment.
Wouldn't it just be better to do ind.write(str(data))
There was a problem hiding this comment.
Seems like it doesn't matter much either way? (would get removed when Py2x is dropped).
|
I need to first port untwisted to python3 then make vy work with python3. I plan to add some features that are py3 related with untwisted, i'll keep this pull request opened, once i have untwisted done for py3 then i merge this pull request. I think in two or three months i'll have time to work on untwisted again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will install vy in the python version that setup.py is called with. i.e:
installs the python2 version on most systems,
installs the python3 version.
Python3 also requires python3-tkinter and python3-pygments. Also requires untwisted in python3 flavor, see there.