This repository has been archived by the owner on Dec 2, 2019. It is now read-only.
Make properties' left and right arrows repeaters; give repeaters adjustable rate & acceleration #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change repeaters so that by default they do not tick every frame and instead tick at a configurable rate Make repeaters' tick rate increase over time as the mouse is held
|
Hi, thanks for the PR. Before going further, could you please change the source files for "paqing"/amalgamation (see |
|
You should consider putting a big warning at the top of nuklear.h that says not to edit it. I have another PR in the works I'll have to redo from scratch now. :( |
|
Sorry for that, I can understand your frustration - feel free to put the warning either to README (e.g. to a section "how to contribute") and/or to the very top of the |
kphillisjr
reviewed
Dec 24, 2018
| @@ -13904,6 +13921,10 @@ nk_input_end(struct nk_context *ctx) | |||
| in->mouse.ungrab = 0; | |||
| in->mouse.grab = 0; | |||
| } | |||
| for (int i = 0; i < NK_BUTTON_MAX; ++i) { | |||
There was a problem hiding this comment.
This line is invalid C89 code. C89 does now allow the definition of variables in the for statement. I recommend copying the style from the nk_input_begin function to fix this issue.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the left/right arrows on properties repeaters, and changes repeaters so they do not tick every frame. The repeaters instead tick at a configurable interval, and the interval decreases the longer you hold the mouse button.