Update retrieving.md #674
Open
Update retrieving.md #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a note for orderBy to point out that you can only order by the model's own field.
cuebit
requested changes
May 6, 2021
| @@ -288,6 +288,9 @@ const users = User.query().orderBy(user => user.name[2]).get() | |||
| */ | |||
| ``` | |||
|
|
|||
| > **NOTE:** orderBy can only order by fields that are native to the model that you are running .query() on. If you want to order by a related model's fields, you have to .sort() the result of the query using your own comparator. | |||
There was a problem hiding this comment.
Can we reword this to make it a little less assertive?
NOTE:
orderBywill order by fields that are native to the model on the currently running query. If you want to order by a related model's fields, you will need to apply sort using your own comparator on the final query result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a note for orderBy to point out that you can only order by the model's own field.
Type of PR:
Breaking changes:
Details
Added a note for orderBy to point out that you can only order by the model's own field.