New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support vue3.4.x to ant-design-vue 3.x #7252
base: 3.x
Are you sure you want to change the base?
Conversation
@tangjinzhou 是否考虑发布兼容版本?目前3.x版本存量用户还有很多 |
components/affix/index.tsx
Outdated
@@ -261,7 +260,8 @@ const Affix = defineComponent({ | |||
]); | |||
return ( | |||
<ResizeObserver onResize={updatePosition}> | |||
<div {...restProps} style={placeholderStyle} ref={placeholderNode}> | |||
<div {...restProps} ref={placeholderNode} data-measure-status={status}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个是不是多了一个 div,再核对下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1
@selicens is this pr stalled? We need this desperately in our project. We have to update Vue to 3.4, but can't update Ant to 4.x because there are too many breaking changes. 🙏 🙏 🙏 |
啥时候能发一版啊,大佬们 |
@tangjinzhou @selicens 唐老师,3.x版本能不能把这个pr合并进去,发个bugfix版本,解决下vue升级到3.4以后出现的问题,毕竟还有不少人在用3.x |
啥时候能发一版啊,大佬们 |
我再跟进一些 |
大佬,有消息吗 |
My company is also being impacted by this. We have multiple widget libraries using ant-design-vue 3.x and new projects with vue 3.4 are broken. |
ant-design-vue 4.x 和vue3.4.x Modal.confirm无法关闭 |
这个没进展了吗 |
自己本地patch个补丁,自己玩自己的 😄 |
这个在 ci 机器上打包用的还是本地 patch 这个包吗 |
shide |
还是没进展吗, |
催催唐老师,我看3.x版本修复了好几个问题,都没有发布,估计是JSX全局命名在3.4没有了,导致一直失败 |
pls support and merge it. thanks |
synch 4.0
#7257