Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add action based on travis file #217

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add action based on travis file #217

wants to merge 1 commit into from
+34 −22

Conversation

vthemelis
Copy link
Contributor

@vthemelis vthemelis commented Mar 29, 2024 •
edited

@vthemelis vthemelis mentioned this pull request Mar 29, 2024
Merged
@vthemelis vthemelis force-pushed the add-gh-action branch 2 times, most recently from 7e93ab8 to 2357105 Compare March 29, 2024 14:27
@vthemelis vthemelis mentioned this pull request Mar 29, 2024
Open
zetashift
zetashift approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@zetashift zetashift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but CI/CD isn't exactly my expertise @sipi

@vthemelis
Copy link
Contributor Author

This now builds on my fork fine. The tests are failing due to a previously introduced regression though.

@vthemelis vthemelis force-pushed the add-gh-action branch 3 times, most recently from 99495b3 to 95bb1d0 Compare April 13, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetashift zetashift zetashift approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vthemelis @zetashift