Selectable timestamp bracket format #132
Conversation
…increment extension version number
|
Hi @Royaljerry, |
|
Thank you. :)
…---
[image: Royaljerry]
Pócs Ádám
Typographer, frontend developer
+36 (30) 361 1541 <//36-30-361-1541> | SKYPE ROYALJERRY |
ROYALJERRY@GMAIL.COM <royaljerry@gmail.com>
FACEBOOK <http://www.facebook.com/royaljerry> | http://be.net/royaljerry
On 2019. January 23. at 17:38:07, Clément Sipieter (notifications@github.com) wrote:
Hi @Royaljerry <https://github.com/Royaljerry>,
thanks for this pull request, I will review it as soon as possible.
6pi
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#132 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADloSTVXzxtRBJ-1ooKTOLHVKBbEr3Ajks5vGI_ugaJpZM4aMvlp>
.
|
|
This is a really nice implementation & adds a degree of customisability to the extension. Looking forward to the merging ☺ |
| @@ -14,7 +14,7 @@ | |||
| "vscode": "^1.23.0" | |||
| }, | |||
| "categories": [ | |||
| "Languages" | |||
| "Programming Languages" | |||
There was a problem hiding this comment.
Probably a good change but not in this PR ;)
| @@ -8,22 +8,22 @@ | |||
|
|
|||
| // A task runner that calls a custom npm script that compiles the extension. | |||
| { | |||
| "version": "0.1.0", | |||
| "version": "2.0.0", | |||
There was a problem hiding this comment.
Probably a good change but not in this PR ;)
|
|
||
| // we want to run npm | ||
| "command": "npm", | ||
|
|
||
| // the command is a shell script | ||
| "isShellCommand": true, | ||
| "type": "shell", |
There was a problem hiding this comment.
Probably a good change but not in this PR ;)
|
|
||
| // show the output window only if unrecognized errors occur. | ||
| "showOutput": "silent", | ||
| "reveal": "silent", |
There was a problem hiding this comment.
Probably a good change but not in this PR ;)
|
|
||
| // we run the custom script "compile" as defined in package.json | ||
| "args": ["run", "compile", "--loglevel", "silent"], | ||
|
|
||
| // The tsc compiler is started in watching mode | ||
| "isWatching": true, | ||
| "isBackground": true, |
There was a problem hiding this comment.
Probably a good change but not in this PR ;)
| @@ -2,7 +2,7 @@ | |||
| "name": "org-mode", | |||
| "displayName": "Org Mode", | |||
| "description": "Emacs Org mode support for VSCode", | |||
| "version": "0.1.3", | |||
| "version": "0.5.1", | |||
There was a problem hiding this comment.
A good change but not in this PR ;)
| @@ -1,6 +1,6 @@ | |||
| // A launch configuration that compiles the extension and then opens it inside a new window | |||
| { | |||
| "version": "0.1.0", | |||
| "version": "2.0.0", | |||
There was a problem hiding this comment.
Probably a good change but not in this PR ;)
There was a problem hiding this comment.
LGTM but I concour with @sipi comments.
Also, we should wait that the change behvaior preseing [] works. :)
Hi team, just enhanced this extension a bit, in order to have a selectable timestamp bracket format. Since I use Beorg app on my iPhone, and it uses the
<YYYY-MM-DD NoD>instead of the avalable[YYYY-MM-DD NoD], I wanted to have this feature. :)Best,
Adam