Checkboxes and summaries #129
Conversation
package.json
Outdated
| }, | ||
| { | ||
| "command": "org.updateSummary", | ||
| "key": "ctrl+alt+o #", |
There was a problem hiding this comment.
I don't think "#" is a valid keybinding in vscode, but I figure most of the default keybindings we have aren't finalized anyhow
There was a problem hiding this comment.
Thanks for review. I replaced '#' with '/', which works. The '#' should have been Shift+3 but it's too many keypresses.
I also added command contribution entries with titles and descriptions.
|
In {
"command": "org.updateSummary",
"title": "Org: Update Summary"
},
{
"command": "org.toggleCheckbox",
"title": "Org: Toggle Checkbox"
} |
|
news ? |
|
Love checkboxes! Thanks! @aboukirev need rebase for fix conflicts. PS: Can test it on my local machine. |
| // Percentage is a cookie indicating the percentage of ticked checkboxes in the child list relative to the total number of checkboxes in the list. | ||
| const percentRegex = /\[(\d*)%\]/; | ||
| const indentRegex = /^(\s*)\S/; | ||
| let orgTabSize: number = 4; |
There was a problem hiding this comment.
Is there a reason to store orgTabSize globally. It can be changed on fly. And potentially break traversing via trees. I think it potentially can have corner-cases here. If I understand your logic correctly (sorry if I'm wrong, just made fast review yet and not JS developer).
Implements nested checkbox lists and summaries (number of checkboxes ticked relative to total number of checkboxes on the same level as ratio or percentage).