build: migrate to eslint flat config format

[ollien]

Modern versions of eslint have migrated to the "flat" configuration style, deprecating .eslintrc.js. I've gone ahead and migrated the project to the new format, which will allow us to safely upgrade to newer versions of eslint. I believe I've preserved all existing rules, but it's a bit hard to prove a negative 😅

The globals dependency is needed due to a change in how the new configuration format handles known globals. See: https://eslint.org/docs/latest/use/configure/migration-guide#configuring-language-options

[xiyaowong]

Nice. I've been wanting to do this for a long time.

Also need to turn on "eslint.experimental.useFlatConfig"

vscode-neovim/.vscode/settings.json

Line 14 in 1fc6752

"eslint.experimental.useFlatConfig": false,

And .eslintignore is no longer supported in Flat config. Just delete it.

[xiyaowong]

I don't understand why it's not "chore" but "build".

[ollien]

I can change the title if you want. I know there were discussions of not using chore so I picked the next best thing. I have no strong opinions one way or the other

[xiyaowong]

😵

[justinmk]

"chore" is a useless prefix. Of course this is either "build" or "lint". Why wouldn't it be?

[xiyaowong]

Should delete .eslintignore

[ollien]

"chore" is a useless prefix. Of course this is either "build" or "lint". Why wouldn't it be?

FYI, lint is not a prefix we allow. From the CI:

allowed-commit-types: feat,fix,docs,style,refactor,test,build,perf,ci,chore,revert,merge,wip

I agree that would be the most fitting here

[justinmk]

lint is not a prefix we allow.

we can add it (and remove "chore")

[xiyaowong]

we can add it

👍🏻

(and remove "chore")

👎🏻

Most front-end projects use something like chore(lint)

[justinmk]

Most front-end projects use something like chore(lint)

Why does that matter?

The problem is that people over-use "chore", it ends up being 30% of the commits. Which defeats the purpose of having a prefix.