Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support up/down for cmdline history #1943

Closed
wants to merge 1 commit into from

Conversation

theol0403
Copy link
Member

Fixes #288

As of microsoft/vscode#211756, arrow keys are now bindable in quickpick.

@theol0403 theol0403 changed the title fix: support up/down in cmdline fix: support up/down for cmdline history May 5, 2024
@theol0403
Copy link
Member Author

I think more thought should be put towards how we handle navigating the suggestions.

My proposal: arrows navigate history, C-n/C-p navigate suggestions. Perhaps we can be clever and say that C-n/C-p navigate history when there are no suggestions, but that might be more tricky.

@ollien
Copy link
Collaborator

ollien commented May 5, 2024

I think that's a good default, but the surrounding UX could stand to be explored. My from-the-hip suggestion would be that going "down" go back in history if there are no suggestions, or "enter the suggestion list" if there are. If you're in the suggestion list, up goes to the previous item, or the command box if you're already at the top.

Or maybe we can 80/20 this and just put in the title of the tooltip "C-n/C-p to navigate suggestions" or some such.

@ollien
Copy link
Collaborator

ollien commented May 12, 2024

Any reason not to merge this at this time?

@theol0403
Copy link
Member Author

I haven't had time to look into this but the risk is that it currently removes the ability to select and accept suggestions using the keyboard.

@theol0403
Copy link
Member Author

I'm cooking up something better 👀

@theol0403 theol0403 closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: arrows don't work for cmdline history navigation
3 participants