chore: remove the language collection types #3431
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to the TypeScript `satisfies` operator, keys from `languages` can be accessed in a type-safe manner, without the need for the `ILanguageCollection` and `INativeLanguageCollection` types. This saves the need to track the languages in multiple places.
remcohaszing
changed the title
|
@remcohaszing thanks for this! It's an improvement for new contributors! I'll approve and merge according to your recommendation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to the TypeScript
satisfiesoperator, keys fromlanguagescan be accessed in a type-safe manner, without the need for theILanguageCollectionandINativeLanguageCollectiontypes. This saves the need to track the languages in multiple places.This will cause merge conflicts with existing pull requests that register a new language. I recommend to merge this last before making a new release, so only one merge conflict needs to be resolved.