Add sites_enabled_path and streams_enabled_path param #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @feltra, thanks for the PR. Can you please rebase against our master branch and check for the failed travis tests? |
bastelfreak
reviewed
Jun 10, 2019
| @@ -52,6 +52,7 @@ | |||
| $sites_available_owner = $nginx::params::sites_available_owner, | |||
| $sites_available_group = $nginx::params::sites_available_group, | |||
| $sites_available_mode = $nginx::params::sites_available_mode, | |||
| $sites_enabled_path = $nginx::params::sites_enabled_path, | |||
There was a problem hiding this comment.
Please add a Datatype like String[1] to this
bastelfreak
reviewed
Jun 10, 2019
| @@ -97,6 +98,7 @@ | |||
| $log_format = {}, | |||
| Boolean $mail = false, | |||
| Boolean $stream = false, | |||
| $streams_enabled_path = $nginx::params::sites_enabled_path, | |||
There was a problem hiding this comment.
Please add a Datatype like String[1] to this
|
Ping @feltra :) |
|
Dear @feltra, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
1 similar comment
|
Dear @feltra, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to change path for sites-enabled and streams-enabled keeping it within conf dir.
related to: #1234 and #1302
Pull Request (PR) description
This Pull Request (PR) fixes the following issues