Add version parameter to homeassistant class #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puppet-python no longer uses virtualenv parameter. This commit removes the virtualenv parameter from the `python` class.
Allow the version to be specified in the pip install. Add a `version` parameter to the `homeassistant` class which makes sure that this version is installed in the virtual environment.
bastelfreak
reviewed
Apr 3, 2022
| @@ -9,6 +9,7 @@ | |||
| Stdlib::Absolutepath $home = '/srv/homeassistant', | |||
| Stdlib::Absolutepath $confdir = '/etc/homeassistant', | |||
| Boolean $known_devices_replace = false, | |||
| String $version = 'present', | |||
There was a problem hiding this comment.
which values are allowed here? Could you make this an enum maybe?
|
thanks for the PR! Could you please rebase this against our latest master? |
|
Dear @lordievader, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Add version specification to the
homeassistantclass. This way you can pin the version from your Puppet code, or have Puppet update your Homeassistant installation.This Pull Request (PR) fixes the following issues