Don't overwrite default users and roles when creating the directory

[choffee]

I think this fixes things but I have run out of time now to check the rest.

Pull request acceptance prerequisites:

• Signed the CLA (if not already signed)
• Rebased/up-to-date with base branch
• Tests pass
• Updated CHANGELOG.md with patch notes (if necessary)
• Updated CONTRIBUTORS (if attribution is requested)

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[tylerjl]

@choffee the module actually operates by changing those user files in /etc/elasticsearch and copying them into instance directories, so the the results of this change would just be that instance directories would no longer get user/role changes. What specific issue are you running into that's prompting this PR?

[fatmcgav]

Hi there,

Firstly, thank you for taking the time to contribute, and apologies for the radio silence from Elastic on this PR.

I'm going to be working on this module over the next few weeks, with an ultimate aim of updating the module to support the elasticsearch 7.x and simplifying the module to make it easier to use.

I'll be reviewing all the open issues and PRs over the next few days, and will merge or provide feedback where appropriate.

So please hang in there whilst we give this module some TLC.

Thanks again.

[fatmcgav]

@choffee I've labelled this PR as wontfix, as the plan is to remove the support for configuring multiple instances on a single node as part of the updates to support Elasticsearch 7.x.

I'll leave the PR open until those changes have been made to ensure that the scenario is account for.

Please let me know if you have any further questions.

[vox-pupuli-tasks]

Dear @choffee, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

[vox-pupuli-tasks]

Dear @choffee, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks