Update cli_platform tests to use 'const' correctly #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests of the platform resolution for the various 'volta run' scenarios were using a lazily-loaded 'const' value. Clippy raised some warnings about those, as 'const' values are actually duplicated for each location they are used, so the interior mutability wasn't helpful. It seems that the `Lazy` behavior was actually a way to work around the fact that `Version` doesn't have a 'const' constructor, however all of the fields are `pub`, so we can construct the values directly. This allows us to have a true `const` value and use it in each test without needing extra interior mutability or cloning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
The tests of the platform resolution for the various 'volta run' scenarios were using a lazily-loaded 'const' value. Clippy raised some warnings about those, as 'const' values are actually duplicated for each location they are used, so the interior mutability wasn't helpful.
It seems that the
Lazybehavior was actually a way to work around the fact thatVersiondoesn't have a 'const' constructor, however all of the fields arepub, so we can construct the values directly. This allows us to have a trueconstvalue and use it in each test without needing extra interior mutability or cloning.Changes
NODE_VERSION,NPM_VERSION, andYARN_VERSIONconstants used in thecli_platformtests to be directly defined, rather than lazy loaded.Tested