Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix job clone miss PgUID #3462

Merged
merged 1 commit into from May 24, 2024
Merged

Conversation

lowang-bh
Copy link
Member

@lowang-bh lowang-bh commented May 11, 2024

PgUID is missed when clone job.

Signed-off-by: lowang-bh <lhui_wang@163.com>
@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 11, 2024
@Monokaix
Copy link
Member

Seems that we not use pguid in session cache but just in scheduer cache currently.
But it's also reasonable to do that.

@lowang-bh
Copy link
Member Author

@hwdef @william-wang

@lowang-bh
Copy link
Member Author

Seems that we not use pguid in session cache but just in scheduer cache currently. But it's also reasonable to do that.

Year, current it is not used. But when it is used in a cloned job, there will be a bug.

@lowang-bh
Copy link
Member Author

/assign @Monokaix @hwdef

Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2024
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2024
@volcano-sh-bot volcano-sh-bot merged commit c9c6155 into volcano-sh:master May 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants