Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log when outputting preempt error #3447

Merged
merged 1 commit into from May 23, 2024
Merged

fix: log when outputting preempt error #3447

merged 1 commit into from May 23, 2024

Conversation

googs1025
Copy link
Contributor

@googs1025 googs1025 commented Apr 28, 2024 •
edited

What type of PR is this?

log when outputting preempt error

What this PR does / why we need it:

  • log when outputting preempt error：preempt should be an important method. If an error occurs, a log should be printed.
  • refector the judgment statement of allocate action to make it more readable

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 28, 2024
@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 28, 2024
@volcano-sh-bot volcano-sh-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 28, 2024
@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 30, 2024
@googs1025 googs1025 requested a review from lowang-bh May 1, 2024 12:38
@googs1025 googs1025 requested a review from Monokaix May 9, 2024 14:50
@volcano-sh-bot volcano-sh-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2024
@volcano-sh-bot volcano-sh-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2024
lowang-bh
lowang-bh reviewed May 11, 2024
View reviewed changes
pkg/scheduler/actions/preempt/preempt.go Outdated Show resolved Hide resolved
pkg/scheduler/actions/preempt/preempt.go Outdated Show resolved Hide resolved
@googs1025 googs1025 force-pushed the refector_preempt branch 2 times, most recently from a0bea73 to 6365091 Compare May 11, 2024 13:17
@googs1025 googs1025 requested a review from lowang-bh May 13, 2024 15:06
lowang-bh
lowang-bh reviewed May 14, 2024
View reviewed changes
pkg/scheduler/actions/preempt/preempt.go Outdated Show resolved Hide resolved
pkg/scheduler/actions/preempt/preempt.go Outdated Show resolved Hide resolved
@googs1025
fix: log when outputting preempt error
e74d9c6 
Signed-off-by: googs1025 <googs1025@gmail.com>
@googs1025 googs1025 requested a review from lowang-bh May 14, 2024 08:42
@googs1025
Copy link
Contributor Author

@lowang-bh @Monokaix /PTAL thanks!

@lowang-bh
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@Monokaix
Copy link
Member

/lgtm

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lowang-bh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2024
@volcano-sh-bot volcano-sh-bot merged commit 0dc370d into volcano-sh:master May 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lowang-bh lowang-bh lowang-bh approved these changes

@Thor-wl Thor-wl Awaiting requested review from Thor-wl

@Monokaix Monokaix Awaiting requested review from Monokaix

Assignees

@Monokaix Monokaix

@lowang-bh lowang-bh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@googs1025 @lowang-bh @Monokaix @volcano-sh-bot