Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter out those nodes which are UnschedulableAndUnresolvable when preempting #3432

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lowang-bh
Copy link
Member

@lowang-bh lowang-bh commented Apr 21, 2024

Fixes #3071
Part of enhancement for preemption action #3074
Those nodes with status UnschedulableAndUnresolvable is not helpful for preempting. So we can use cached predicating result to reduce the nodes numbers when scan for a victim pod.

we can also use the new Api NewFitStatus to return an error in predicating to fix issue Predicate function retrun value is not compatiable with old plugins #3086

main changes:
commit-1: add predicate result code to task's fitError
commit-2: testcase about fitErrors
commit-3: filter out those nodes which are not helpful for preemption in preempt/reclaim actions

@volcano-sh-bot volcano-sh-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 21, 2024
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign lowang-bh
You can assign the PR to them by writing /assign @lowang-bh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 21, 2024
@volcano-sh-bot volcano-sh-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 17, 2024
@lowang-bh lowang-bh changed the title (WIP)improve: filter out those nodes which are UnschedulableAndUnresolvable when preempting filter out those nodes which are UnschedulableAndUnresolvable when preempting May 17, 2024
@volcano-sh-bot volcano-sh-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2024
@lowang-bh
Copy link
Member Author

/assign @Monokaix @hwdef @wangyang0616

@volcano-sh-bot volcano-sh-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 18, 2024
@lowang-bh
Copy link
Member Author

@volcano-sh-bot volcano-sh-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 25, 2024
used in preempting

Signed-off-by: lowang-bh <lhui_wang@163.com>
Signed-off-by: lowang-bh <lhui_wang@163.com>
Signed-off-by: lowang-bh <lhui_wang@163.com>
@volcano-sh-bot volcano-sh-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filterout those nodes which are not helpful for preemptation
6 participants