-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filter out those nodes which are UnschedulableAndUnresolvable when preempting #3432
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @Monokaix @hwdef @wangyang0616 |
/assign @Monokaix @hwdef @wangyang0616 @william-wang |
241d974
to
9509548
Compare
used in preempting Signed-off-by: lowang-bh <lhui_wang@163.com>
Signed-off-by: lowang-bh <lhui_wang@163.com>
Signed-off-by: lowang-bh <lhui_wang@163.com>
Fixes #3071
Part of enhancement for preemption action #3074
Those nodes with status UnschedulableAndUnresolvable is not helpful for preempting. So we can use cached predicating result to reduce the nodes numbers when scan for a victim pod.
we can also use the new Api
NewFitStatus
to return an error in predicating to fix issue Predicate function retrun value is not compatiable with old plugins #3086main changes:
commit-1: add predicate result code to task's fitError
commit-2: testcase about fitErrors
commit-3: filter out those nodes which are not helpful for preemption in preempt/reclaim actions