Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log info or error print #3410

Merged
merged 1 commit into from May 24, 2024
Merged

fix: log info or error print #3410

merged 1 commit into from May 24, 2024
+13 −16

Conversation

googs1025
Copy link
Contributor

  • found some typo or code style err
  • fix log print level

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 13, 2024
@googs1025 googs1025 force-pushed the fix_log branch 2 times, most recently from d3b8de4 to 0c42e04 Compare April 13, 2024 17:12
@googs1025
Copy link
Contributor Author

/restart

@googs1025 googs1025 force-pushed the fix_log branch 2 times, most recently from f444538 to 3888c02 Compare April 14, 2024 05:09
lowang-bh
lowang-bh reviewed Apr 16, 2024
View reviewed changes
pkg/scheduler/actions/reclaim/reclaim.go Outdated Show resolved Hide resolved
pkg/scheduler/actions/backfill/backfill.go Outdated Show resolved Hide resolved
pkg/scheduler/actions/reclaim/reclaim.go Outdated Show resolved Hide resolved
@lowang-bh
Copy link
Member

others lgtm
/assign @Monokaix @hwdef

@googs1025 googs1025 force-pushed the fix_log branch 2 times, most recently from 8318f99 to f763733 Compare April 16, 2024 05:25
@googs1025
Copy link
Contributor Author

@Monokaix @hwdef /PTAL just fix typo and log level

@lowang-bh
Copy link
Member

/lgtm

Please rebase and squash commits to only one.

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2024
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2024
@googs1025
Copy link
Contributor Author

@lowang-bh done

@lowang-bh
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
hwdef
hwdef reviewed Apr 25, 2024
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2024
hwdef
hwdef reviewed May 10, 2024
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2024
@volcano-sh-bot volcano-sh-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 10, 2024
@googs1025 googs1025 force-pushed the fix_log branch 2 times, most recently from 78b417a to 03092f6 Compare May 10, 2024 10:12
@volcano-sh-bot volcano-sh-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 10, 2024
@volcano-sh-bot volcano-sh-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2024
@googs1025 googs1025 requested review from lowang-bh and hwdef May 21, 2024 14:15
@googs1025 googs1025 force-pushed the fix_log branch 2 times, most recently from 937cc18 to 551fc19 Compare May 22, 2024 04:58
@googs1025
fix: log info or error print
afefd31 
Signed-off-by: googs1025 <googs1025@gmail.com>

fix: log level

Signed-off-by: googs1025 <googs1025@gmail.com>
@volcano-sh-bot volcano-sh-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 22, 2024
lowang-bh
lowang-bh reviewed May 22, 2024
View reviewed changes
Copy link
Member

@lowang-bh lowang-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2024
william-wang
william-wang approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lowang-bh, william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2024
@volcano-sh-bot volcano-sh-bot merged commit f41ae8a into volcano-sh:master May 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monokaix Monokaix Monokaix left review comments

@lowang-bh lowang-bh lowang-bh approved these changes

@william-wang william-wang william-wang approved these changes

@alcorj-mizar alcorj-mizar Awaiting requested review from alcorj-mizar

@archlitchi archlitchi Awaiting requested review from archlitchi

@hwdef hwdef Awaiting requested review from hwdef

Assignees

@william-wang william-wang

@hwdef hwdef

@Monokaix Monokaix

@lowang-bh lowang-bh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@googs1025 @lowang-bh @volcano-sh-bot @william-wang @hwdef @Monokaix