-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network Topology Aware Plugin #3388
base: master
Are you sure you want to change the base?
Conversation
/assign @Monokaix @hwdef @william-wang |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
we should talk this in weekly meeting. |
Sounds interesting!But it's maybe more complex than the given desgin. For example, network delay varies between different nodes. Also, it varies in different period to the same node. Maybe considering with network performance metrics for this feature will be a good choice. I think we should take a discussion in the community and complete the design first. |
What's the difference between this and https://github.com/kubernetes-sigs/scheduler-plugins/tree/master/pkg/networkaware? |
I would like to recommend to treat the network performace metrics as a kind of load, so it's more like a loadaware scheduling.
Now it is not considered. This plugin just conserder the physical difference in topology. |
I think it is a lite one of that plugin, just consider several physical topology, such as idc, rock, switch, and depend on those labels on nodes. advantage: more simply to use, just rely on node labels |
We should collect more user cases: ) |
3. If a node has multiple keys same as the configured list, the first key matching the configured keys has higher score | ||
|
||
```go | ||
nodeOrderFn := func(task *api.TaskInfo, node *api.NodeInfo) (float64, error){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the original user demand, job should occupy nodes exclusively, so only nodeorder func seems cannot satisfy the original use case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean a predicateFn is need?
Signed-off-by: lowang-bh <lhui_wang@163.com>
Signed-off-by: lowang-bh <lhui_wang@163.com>
/kind feature
fixes #2984
fixes #447
fixes #3317
There are several issues request this feature, such as #447 #2984 #3317
Motivation
We target to make scheduler net-topology aware so as to achieve the following:
Goals
Non-Goals