Feature/allow helm config overrides #3354
Merged
+34
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @lukasboettcher! |
volcano-sh-bot
added
the
size/M
lukasboettcher
force-pushed
the
feature/allow-helm-config-overrides
branch
2 times, most recently
from
d59a894
to
9081402
Compare
|
/assign @k82cn |
|
/ok-to-test |
volcano-sh-bot
added
the
ok-to-test
|
/test all |
|
@lukasboettcher please rebase and squash your commits to only one. |
lukasboettcher
force-pushed
the
feature/allow-helm-config-overrides
branch
2 times, most recently
from
53aa558
to
203fce9
Compare
Signed-off-by: lukasboettcher <1340215+lukasboettcher@users.noreply.github.com>
lukasboettcher
force-pushed
the
feature/allow-helm-config-overrides
branch
from
203fce9
to
d78b48b
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to configure the admission and scheduler configuration via helm values.