Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add podgroup unenqueueable condition type and un-enqueueable reason #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add podgroup unenqueueable condition type and un-enqueueable reason #113

wants to merge 1 commit into from

Conversation

lowang-bh
Copy link
Member

@lowang-bh lowang-bh commented Aug 12, 2023 •
edited

@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign thor-wl
You can assign the PR to them by writing /assign @thor-wl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lowang-bh lowang-bh mentioned this pull request Aug 12, 2023
Open
@lowang-bh
Copy link
Member Author

lowang-bh commented Aug 13, 2023 •
edited

@Thor-wl @hwdef @wangyang0616 Please help to review and merge it before volcano's relative PR.

Thor-wl
Thor-wl reviewed Aug 16, 2023
View reviewed changes
Copy link
Member

@Thor-wl Thor-wl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask about the requirement and scenario of this PR? Suggest to add descriptions about that.

@lowang-bh
Copy link
Member Author

May I ask about the requirement and scenario of this PR? Suggest to add descriptions about that.

Hi, @Thor-wl docs added at volcano-sh/volcano#3065

@lowang-bh
Copy link
Member Author

/assign @william-wang @Thor-wl

@lowang-bh
feat: add podgroup uninqueueable condition type and un-enqueueable re…
941bf2d 
…ason

Signed-off-by: lowang-bh <lhui_wang@163.com>
@lowang-bh
Copy link
Member Author

Hi, @william-wang , any update here?

@Monokaix
Copy link
Member

Hi, please update code geneate.

@lowang-bh
Copy link
Member Author

Hi, please update code geneate.

There is no changes after running bash ./hack/update-codegen.sh.

@william-wang william-wang changed the title feat: add podgroup uninqueueable condition type and un-enqueueable reason feat: add podgroup unenqueueable condition type and un-enqueueable reason Dec 14, 2023
@Monokaix
Copy link
Member

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@william-wang william-wang william-wang left review comments

@Thor-wl Thor-wl Thor-wl left review comments

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

Assignees

@william-wang william-wang

@Monokaix Monokaix

@Thor-wl Thor-wl

Labels
lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lowang-bh @volcano-sh-bot @Monokaix @william-wang @Thor-wl