Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3-language-server: update to 0.36.2 #34180

Closed
wants to merge 1 commit into from

Conversation

jgarte
Copy link
Contributor

@jgarte jgarte commented Nov 21, 2021

  • python3-language-server: update to 0.36.2

  • I tested the changes in this PR: YES

  • I built this PR locally for my native architecture, (x86_64)

@jgarte jgarte changed the title pylsp python3-language-server: update to 0.36.2 Nov 21, 2021
@jgarte
Copy link
Contributor Author

jgarte commented Nov 21, 2021

Linter is saying:

srcpkgs/python3-language-server/template:4: revision should be set to 1 on update

I bumped the revision. Should I really be setting it back to 1?

@paper42
Copy link
Member

paper42 commented Nov 21, 2021

Linter is saying:

srcpkgs/python3-language-server/template:4: revision should be set to 1 on update

I bumped the revision. Should I really be setting it back to 1?

Yes, revisions are for making sure the package gets built users can get the update - 1.0.0_2 is newer than 1.0.0_1. When the version is increased, we can reset revision because the update will be detected - 1.0.1_1 is newer than 1.0.0_4.

@ericonr
Copy link
Member

ericonr commented Nov 21, 2021

palantir/python-language-server#935 seems relevant. I wonder if we should package that new one.

@jgarte
Copy link
Contributor Author

jgarte commented Nov 22, 2021

palantir/python-language-server#935 seems relevant. I wonder if we should package that new one.

@ericonr

Yup, I agree we should package the new one instead of this PR.

@jgarte
Copy link
Contributor Author

jgarte commented Nov 22, 2021

Got it! Thanks for the explanation.

@jgarte
Copy link
Contributor Author

jgarte commented Nov 22, 2021

Closing this in favor of #34192

@jgarte jgarte closed this Nov 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants