Fix #4 - indentation error #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
discosultan
reviewed
Feb 26, 2020
| for index, row in data.iterrows(): | ||
| if row[high_col] != row[low_col]: | ||
| val = val_last + ((row[close_col] - row[low_col]) - (row[high_col] - row[close_col])) / (row[high_col] - row[low_col]) * row[vol_col] | ||
| else: | ||
| val = val_last | ||
| ac.set_value(index, val) | ||
| val_last = val | ||
| val_last = val |
There was a problem hiding this comment.
Setting val_last outside the for loop seems meaningless. Should it be indented even more, so it's part of the loop (note I do not know the actual algorithm behind Chaikin Oscillator)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error occurs and generated a import error. Fix it.