RFC: Relive Timelens support #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add timelens support for Relive recordings. This works similarly to the current scrub thumbs, but is mutually exclusive with it as both features overlap technologically as well as from a user perspective.
Currently, the Timelens CSS gets added dynamically because loading it indiscriminately results in artifacts in the player. Not sure if we either need a portable way to do this in JS (
h()cannot be used, as it's a PHP function and templating the JS with PHP doesn't seem to be a sane solution) or if this can be fixed on the Timelens side. Comments welcome.