Expose max concurrent connection config option [full ci] #8678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hickeng
added
kind/enhancement
hickeng
changed the title
hickeng
force-pushed
the
topic/max-concurrent-connections
branch
from
811fe0c
to
95eea52
Compare
This adds an option to set the maximum number of concurrent connections to vCenter that will be used by the port layer. This does NOT effect the admin server, and admin server connections do not count towards the maximum for the port layer. This adds a --max-concurrent-connections (--mcc short form) option to create and configure, allowing setting between 2 (because port layer requires 2 minimum to initialize) and 255 (because it's a sane upper limit, given default has been 32 since 2017, but with no reason beyond that). This has NOT made the necessary changes for this option to be available via the VIC LCM API and vCenter UI extension. Testing so far has been via manual use of CLI.
Prior test was unnecessarily complex and resulting in a non-useful message in error case The automation token can be added into drone using the drone cli: * drone secret add or * login to the drone webui, go to profile->secrets, and update via the box in the top right https://ci-vic.vmware.com/vmware/vic/settings/secrets at time of writing
hickeng
force-pushed
the
topic/max-concurrent-connections
branch
from
95eea52
to
878f91c
Compare
|
[full ci] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to set the maximum number of concurrent connections
to vCenter that will be used by the port layer.
This does NOT effect the admin server, and admin server connections do
not count towards the maximum for the port layer.
This adds a --max-concurrent-connections (--mcc short form) option to
create and configure, allowing setting between 2 (because port layer
requires 2 minimum to initialize) and 255 (because it's a sane upper
limit, given default has been 32 since 2017, but with no reason beyond
that).
This has NOT made the necessary changes for this option to be available
via the VIC LCM API and vCenter UI extension.
Testing so far has been via manual use of CLI.
Also rolls in minor fixes in the bash-helpers and linting.
[full ci]