Modify --registry-ca flag's help info #8500
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YanzhaoLi
requested review from
renmaosheng,
wjun,
luwang-vmware and
DanielXiao
and removed request for
renmaosheng
wjun
reviewed
Mar 19, 2019
cmd/vic-machine/common/registries.go
Outdated
| @@ -40,7 +40,7 @@ func (r *Registries) Flags() []cli.Flag { | |||
| return []cli.Flag{ | |||
| cli.StringSliceFlag{ | |||
| Name: "registry-ca, rc", | |||
| Usage: "Specify a list of additional certificate authority files to use to verify secure registry servers", | |||
| Usage: "Specify a list of certificate authority files to replace old ones to verify secure registry servers", | |||
There was a problem hiding this comment.
For the first time, there is no any existing ones, so I suggest to remove "replace old ones" here.
Specify the replace behavior of --registry-ca flag
YanzhaoLi
force-pushed
the
topic/modify-registry-ca-help-info
branch
from
529017f
to
c0ed946
Compare
wjun
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify the
replacebehavior of--registry-caflagFixes #8176