Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run portlayer as un-privileged user #8441

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Run portlayer as un-privileged user #8441

wants to merge 1 commit into from

Conversation

DanielXiao
Copy link
Contributor

@DanielXiao DanielXiao commented Jan 3, 2019 •
edited

Start portlayer process with vicadmin user and give cap_sys_admin
capability to it.

Fixes #4315

@DanielXiao DanielXiao requested a review from a team as a code owner January 3, 2019 09:46
YanzhaoLi
YanzhaoLi reviewed Jan 3, 2019
View reviewed changes
Copy link
Member

@YanzhaoLi YanzhaoLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to chown the /sbin/port-layer-server to vicadmin:vicadmin ?

@DanielXiao
Run portlayer as un-privileged user
0dbc953 
Start portlayer process with vicadmin user and give capabilities of
mounting disks and binding a port less than 1024.
@DanielXiao
Copy link
Contributor Author

No. port-layer-server 's permission is 755 so other user can execute it.

@DanielXiao DanielXiao mentioned this pull request Jan 4, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YanzhaoLi YanzhaoLi YanzhaoLi left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanielXiao @YanzhaoLi @vmwclabot