Update extension of volume policies design #7803
Closed
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> add changelog Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
shubham-pampattiwar
force-pushed
the
update-ext-vol-policy-design
branch
from
fc80d49
to
2adb0a6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7803 +/- ##
=======================================
Coverage 58.67% 58.67%
=======================================
Files 345 345
Lines 28739 28739
=======================================
Hits 16862 16862
Misses 10448 10448
Partials 1429 1429 ☔ View full report in Codecov by Sentry. |
|
@shubham-pampattiwar @blackpiglet |
sseago
approved these changes
May 17, 2024
|
Because #7794 already included the design change of VolumePolicy, we can close this PR. |
|
@shubham-pampattiwar I'm closing this one, please ping me on slack if there's different opinion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Update extension of volume policies design
Remove requirement of
snapshotVolumesflag forsnapshotactionPlease indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.