-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testifylint: enable error-nil rule #7670
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7670 +/- ##
==========================================
- Coverage 58.79% 58.77% -0.03%
==========================================
Files 345 345
Lines 28764 28764
==========================================
- Hits 16911 16905 -6
- Misses 10425 10430 +5
- Partials 1428 1429 +1 ☔ View full report in Codecov by Sentry. |
1e221bb
to
56d93d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v1.14.0 FC is not far away. Suggest to put on hold of this PR until release-1.14 branch is cut.
0b23fdb
to
e1125a0
Compare
Hi @blackpiglet , |
f8a2aa6
to
7a9fc3f
Compare
@mmorel-35 |
2f0950b
to
92200ef
Compare
@mmorel-35 |
92200ef
to
28e40df
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
28e40df
to
330fe0f
Compare
@blackpiglet, that’s ready 👍! |
Please add a summary of your change
testifylint: enable error-nil rule
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.