[CI/Build] Enable entrypoints tests to be run in a single command #4759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With the change in #4328, entrypoints tests cannot be run in a single command anyway. I have switched to using pytest markers to separate the tests in that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting
gpu_memory_utilizationto a low value for tests that only use small models, allentrypointstests can now be run in a single command.However, I now get this warning when running
test_oot_registration_for_api_serverafter changingmultiprocessingto use the'spawn'start method instead of the default'fork':Does this mean the OS has to restart in order to clean this memory leak? Hopefully it won't become a significant issue.