[CI/Build] use setuptools-scm to set __version__ #4738
Draft
+50
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrifiro
force-pushed
the
use-setuptools-scm
branch
from
88c1923
to
d5ce8a3
Compare
dtrifiro
commented
May 10, 2024
| @@ -71,7 +71,8 @@ ENV NVCC_THREADS=$nvcc_threads | |||
| ENV VLLM_INSTALL_PUNICA_KERNELS=1 | |||
|
|
|||
| ENV CCACHE_DIR=/root/.cache/ccache | |||
| RUN --mount=type=cache,target=/root/.cache/ccache \ | |||
| RUN --mount=type=bind,source=.git,target=.git \ | |||
There was a problem hiding this comment.
Note that it's required to bind-mount the .git dir in order to be able to extract git information during the build process
dtrifiro
force-pushed
the
use-setuptools-scm
branch
from
d5ce8a3
to
6a39d1e
Compare
dtrifiro
force-pushed
the
use-setuptools-scm
branch
4 times, most recently
from
7e88767
to
30f1baa
Compare
dtrifiro
force-pushed
the
use-setuptools-scm
branch
2 times, most recently
from
954eef3
to
d363942
Compare
dtrifiro
force-pushed
the
use-setuptools-scm
branch
from
d363942
to
261200a
Compare
|
@andy-neuma PTAL |
1 similar comment
|
@andy-neuma PTAL |
|
Waiting on #4791 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using setuptools-scm, we can get versioning information directly from git.
This PR includes changes to Dockerfiles in order correctly build including setuptools-scm.