Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: don't exit process if config failed #5715

Merged
merged 4 commits into from May 13, 2024

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented May 13, 2024

Description

An error in this function already triggers error handling here:

This affects public API - it's no longer needed to overwrite process.exit when initiating Vitest because there was no way to intercept this error.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sheremet-va sheremet-va changed the title fix: don't exit process if config failed fix!: don't exit process if config failed May 13, 2024
@sheremet-va sheremet-va merged commit f232fdd into vitest-dev:main May 13, 2024
17 checks passed
@sheremet-va sheremet-va deleted the fix/dont-exit-on-config-fail branch May 13, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant