Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run flaky tests on GitHub action #4902

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bonyuta0204
Copy link
Contributor

@bonyuta0204 bonyuta0204 commented Jan 8, 2024

Description

Woriking in Progress.
Trying to address #4464

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit c3134f4
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65a7fcbb31572500080e838d
😎 Deploy Preview https://deploy-preview-4902--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

// TODO: Fix flakiness and enable on CI
if (process.env.GITHUB_ACTIONS)
test.only('skip tests on CI', () => {})

test('editing source file triggers re-run', async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the flakiness in files that rely on watch mode might be due to the watcher incorrectly emitting ready event too soon. You can try incorporating the utility I wrote for Vite tests from here: https://github.com/sheremet-va/vite/blob/4df5ac29087f448a40f80707dec78d197e74c6d2/playground/hmr-ssr/__tests__/hmr.spec.ts#L960

We already check for a ready event with an env variable for tests (maybe it can be improved with the utility here):

if (process.env.VITE_TEST_WATCHER_DEBUG) {

if (options.watch && process.env.VITE_TEST_WATCHER_DEBUG) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your advice!
I will check it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants