Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser): support more browsers #4320

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

edoardocavazza
Copy link

Description

This PR solves #4304 adding the es2017 target to builds and polyfilling globalThis in html entrypoints.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit 043ee00
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/652e393fa4d59f00086af87a

@sheremet-va
Copy link
Member

We should not polyfill anything by default.

@edoardocavazza
Copy link
Author

I see. I've removed the polyfill for globalThis, which will narrow down the list of supported browsers a bit, particularly excluding Safari versions up to 12.2, but I think it should still work.

Copy link
Member

@sheremet-va sheremet-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add spy package here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants