-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix): don't calculate statistics for masks #1867
base: main
Are you sure you want to change the base?
Conversation
let domains = defaultSelection.map(i => [0, 255]) | ||
let sliders = defaultSelection.map(i => [0, 255]) | ||
let colors = defaultSelection.map((_, i) => PALETTE[i]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure of a better way to do this - maybe if-then instead of default and then an if statement to change? But the assignment operation is inexpensive. I think the first two defaults don't matter anyway, and the colors
seems reasonable but not sure of the default palette for this.
Size Change: +381 B (+0.01%) Total Size: 6.43 MB ℹ️ View Unchanged
|
TODO: fix the opacity causing loads edit: maybe this is not happening? can't reproduce now |
What's up with the size action also? |
Coverage Report
File Coverage
|
Background
Something I noticed while playing around is that we were calculating stats for masks as well. So this PR should fix that. I am open to other options for this!
Change List
isBitmask
argument toinitializeLayerChannels
to stop stats calculation for masksChecklist
vitessce-python
andvitessce-r
if this is a release PR